ui: fix systevmtype for create service offering form#4683
Merged
DaanHoogland merged 1 commit intoapache:4.15from Feb 23, 2021
Merged
ui: fix systevmtype for create service offering form#4683DaanHoogland merged 1 commit intoapache:4.15from
DaanHoogland merged 1 commit intoapache:4.15from
Conversation
Fixes apache#4682 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
yadvr
approved these changes
Feb 12, 2021
harikrishna-patnala
approved these changes
Feb 16, 2021
Member
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Tested on live QA setup, LGTM
Contributor
|
@shwstppr I see more than 2 OKs and manual testing has been done. Do we need more or do you want to merge now? |
Contributor
Author
|
@DaanHoogland ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4682
Adds systemvmtype param in API call
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?